-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(replay): add tracing and metrics to summary endpoint #98494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+137
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellewzhang
approved these changes
Aug 28, 2025
…iu/summary-tracing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mz/fix-ip-query #98494 +/- ##
===================================================
+ Coverage 81.16% 81.18% +0.02%
===================================================
Files 8540 8544 +4
Lines 375739 376941 +1202
Branches 23885 23885
===================================================
+ Hits 304972 306025 +1053
- Misses 70401 70550 +149
Partials 366 366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the methods of this endpoint with a custom transaction. Sampling rates will be options-controlled. We need a high POST sample rate while we develop this feature, to debug slow loading times.
I believe options can be segmented by user email, or something like is_employee - will experiment
Merge together with #98479