fix(replay): lower number of placeholder rows in new issues table in releases drawer #98493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes REPLAY-213
Previously, the new issues table in the releases drawer had an excessive amount of placeholders on load. Here we add a required
numPlaceholderRowsprop to theGroupListcomponent so that a manual number must be set. For other instances using this component, we can pass thequeryParams.limit(as was previously defaulted) or 4.I have 3 rows set as the number of placeholder rows in the new issues table right now (1 seems like not enough to denote that we're looking at a table; 2 feels weird), but open to feedback on this.
Before:
After:
