ref(uptime): Stop writing uptime_rule #98489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need this anymore to link back to the uptime monitor, we'll be using the detector ID, which is part of the occurrence evidence data.
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Sep 2, 2025
evanpurkhiser
commented
Sep 4, 2025
| @@ -131,19 +131,12 @@ def build_event_data(result: CheckResult, detector: Detector) -> EventData: | |||
| # Received time is the actual time the check was performed. | |||
| received = datetime.fromtimestamp(result["actual_check_time_ms"] / 1000) | |||
|
|
|||
| # XXX(epurkhiser): This can be changed over to using the detector ID in the | |||
| # future once we're no longer using the ProjectUptimeSubscription.id as a tag. | |||
| project_subscription = get_project_subscription(detector) | |||
There was a problem hiding this comment.
There's a way to query for detector's in issues using search now. So we don't even need to store it as a tag.
evanpurkhiser
deleted the
evanpurkhiser/ref-uptime-stop-writing-uptime-rule
branch
armenzg
pushed a commit
that referenced
this pull request
Sep 5, 2025
We don't need this anymore to link back to the uptime monitor, we'll be using the detector ID, which is part of the occurrence evidence data. Should not merge until after we've cut-over the UI to only using detector IDs.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
We don't need this anymore to link back to the uptime monitor, we'll be using the detector ID, which is part of the occurrence evidence data. Should not merge until after we've cut-over the UI to only using detector IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this anymore to link back to the uptime monitor, we'll be
using the detector ID, which is part of the occurrence evidence data.
Should not merge until after we've cut-over the UI to only using
detector IDs.