-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(replays): add more robust as_log_message tests #98482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be a use case: src/sentry/replays/lib/summarize.py.
A library should be generic and totally unrelated to replay. This is coupled to replay so its an implementation detail of the product. You don't have to address on this PR. But eventually it should be moved.
@cmanallen moved! (both that file & the test file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
🚨 for actual test changes: use this view https://github.com/getsentry/sentry/pull/98482/files/9500752d1c341f3a051599c7e5bd40deb8143f18
closes https://linear.app/getsentry/issue/REPLAY-621/create-log-parsing-test-suite-with-real-replay-event-data
as_log_message
. serves as an example for reliable test data that can be referenced in the future. all types inEventType
are testedget_timestamp_unit
returns the correct timestamp based on the real replay datas
when they should bems
sentry/src/sentry/replays/usecases/ingest/event_parser.py
Lines 220 to 256 in 950bfbe