-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore(widget-builder): Remove old code #98476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
narsaynorath
merged 5 commits into
master
from
nar/feat/widget-builder-remove-old-builder-code
Aug 29, 2025
Merged
chore(widget-builder): Remove old code #98476
narsaynorath
merged 5 commits into
master
from
nar/feat/widget-builder-remove-old-builder-code
Aug 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
nsdeschenes
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧼 🧹 😄
Left, a small comment on something else i think could get cleaned up 👀
static/app/views/dashboards/widgetBuilder/components/widgetOnDemandQueryWarning.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old widget builder code. Most of this is deletions, there are some parts where I relocated code or renamed files so the names made sense with the components that were leftover.
The structure of some of these files is a little weird at the moment, but I'll move them in another PR. I want this PR to mainly be deletions before I start restructuring the remaining code that is reused from the old widget builder.