Skip to content

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Aug 28, 2025

Remove old widget builder code. Most of this is deletions, there are some parts where I relocated code or renamed files so the names made sense with the components that were leftover.

The structure of some of these files is a little weird at the moment, but I'll move them in another PR. I want this PR to mainly be deletions before I start restructuring the remaining code that is reused from the old widget builder.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 28, 2025
Copy link

codecov bot commented Aug 28, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11479 1 11478 10
View the top 1 failed test(s) by shortest run time
Widget Builder > ThresholdsStep renders thresholds step
Stack Traces | 1.12s run time
Error: Unable to find an element with the text: Set thresholds. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.findByText (.../buildSteps/thresholdsStep/thresholds.spec.tsx:25:25)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@narsaynorath narsaynorath marked this pull request as ready for review August 28, 2025 21:13
@narsaynorath narsaynorath requested review from a team as code owners August 28, 2025 21:13
Copy link
Contributor

@nsdeschenes nsdeschenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼 🧹 😄

Left, a small comment on something else i think could get cleaned up 👀

@narsaynorath narsaynorath enabled auto-merge (squash) August 29, 2025 14:06
@narsaynorath narsaynorath merged commit 516f8ab into master Aug 29, 2025
45 checks passed
@narsaynorath narsaynorath deleted the nar/feat/widget-builder-remove-old-builder-code branch August 29, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants