feat(replay): query IP for trace connected errors for replay summary #97737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
michellewzhang
force-pushed
the
mz/query-ip
branch
2 times, most recently
from
da5a5c4 to
71041e3
Compare
michellewzhang
force-pushed
the
mz/query-ip
branch
from
71041e3 to
fd240f7
Compare
michellewzhang
commented
Aug 28, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 28, 2025
michellewzhang
added
the
Trigger: Revert
|
PR reverted: c40e63c |
getsentry-bot
added a commit
that referenced
this pull request
Aug 28, 2025
…summary (#97737)" This reverts commit b71d79f. Co-authored-by: michellewzhang <[email protected]>
|
reverting as the trace id query is too slow - this pr does 2 snuba queries per trace id. will followup so that it's instead 2 queries for all trace ids |
michellewzhang
added a commit
that referenced
this pull request
Aug 28, 2025
constantinius
pushed a commit
that referenced
this pull request
Sep 1, 2025
constantinius
pushed a commit
that referenced
this pull request
Sep 1, 2025
…summary (#97737)" This reverts commit b71d79f. Co-authored-by: michellewzhang <[email protected]>
michellewzhang
added a commit
that referenced
this pull request
Sep 3, 2025
…(v2) (#98479) redo of #97737 reverted the old pr as the trace id query was too slow -- it did 2 snuba queries per trace id (bad). this pr instead makes it 2 total queries for all trace ids MERGE WED --------- Co-authored-by: Andrew Liu <[email protected]>
armenzg
pushed a commit
that referenced
this pull request
Sep 5, 2025
…(v2) (#98479) redo of #97737 reverted the old pr as the trace id query was too slow -- it did 2 snuba queries per trace id (bad). this pr instead makes it 2 total queries for all trace ids MERGE WED --------- Co-authored-by: Andrew Liu <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
…summary (#97737)" This reverts commit b71d79f. Co-authored-by: michellewzhang <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Sep 9, 2025
…(v2) (#98479) redo of #97737 reverted the old pr as the trace id query was too slow -- it did 2 snuba queries per trace id (bad). this pr instead makes it 2 total queries for all trace ids MERGE WED --------- Co-authored-by: Andrew Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/REPLAY-581/query-issue-platform-dataset-for-trace-connected-errors
we neglected to query the issue platform dataset when looking for trace connected errors to send to the LLM for context. (we were only querying the errors/event dataset.)
the errors/events dataset does not include feedback, performance issues, etc.
example: not all trace connected errors are logged here: