Skip to content

ref(issues): Remove project from group activity type #92600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

ref(issues): Remove project from group activity type #92600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions static/app/components/events/interfaces/uptime/uptimeDataSection.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,12 @@ describe('Uptime Data Section', function () {
data: {},
id: '2',
dateCreated: '2024-06-21T20:36:51.884284Z',
project,
type: GroupActivityType.SET_RESOLVED,
},
{
data: {},
id: '1',
dateCreated: '2024-06-20T20:36:51.884284Z',
project,
type: GroupActivityType.FIRST_SEEN,
},
];
Expand Down Expand Up @@ -67,28 +65,24 @@ describe('Uptime Data Section', function () {
data: {},
id: '4',
dateCreated: '2024-06-22T22:36:51.884284Z',
project,
type: GroupActivityType.SET_RESOLVED,
},
{
data: {},
id: '3',
dateCreated: '2024-06-22T20:36:51.884284Z',
project,
type: GroupActivityType.SET_REGRESSION,
},
{
data: {},
id: '2',
dateCreated: '2024-06-21T20:36:51.884284Z',
project,
type: GroupActivityType.SET_RESOLVED,
},
{
data: {},
id: '1',
dateCreated: '2024-06-20T20:36:51.884284Z',
project,
type: GroupActivityType.FIRST_SEEN,
},
];
Expand Down
3 changes: 1 addition & 2 deletions static/app/components/feedback/feedbackItem/feedbackActivitySection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,11 @@ function FeedbackActivitySection(props: Props) {
data: n,
type: GroupActivityType.NOTE,
dateCreated: new Date().toISOString(),
project: feedbackItem.project,
user: me,
};
mutators.handleCreate(n, [newActivity, ...feedbackItem.activity], createOptions);
},
[createOptions, feedbackItem.activity, mutators, feedbackItem.project]
[createOptions, feedbackItem.activity, mutators]
);

const handleUpdate = useCallback(
Expand Down
1 change: 0 additions & 1 deletion static/app/components/resolutionBox.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ describe('ResolutionBox', function () {
current_release_version: currentReleaseVersion,
},
dateCreated: new Date().toISOString(),
project,
},
]}
/>
Expand Down
1 change: 0 additions & 1 deletion static/app/stores/groupStore.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ describe('GroupStore', function () {
id: '1',
type: GroupActivityType.NOTE,
dateCreated: '',
project: ProjectFixture(),
data: {text: 'Orginal Text'},
},
],
Expand Down
1 change: 0 additions & 1 deletion static/app/types/group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,6 @@ export enum GroupActivityType {
interface GroupActivityBase {
dateCreated: string;
id: string;
project: Project;
assignee?: string;
issue?: Group;
user?: null | User;
Expand Down
31 changes: 0 additions & 31 deletions static/app/views/issueDetails/groupActivity.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ describe('GroupActivity', function () {
data: {text: 'Test Note'},
dateCreated: '2020-01-01T00:00:00',
user: UserFixture(),
project,
},
],
project,
Expand Down Expand Up @@ -98,7 +97,6 @@ describe('GroupActivity', function () {
type: GroupActivityType.MARK_REVIEWED,
id: 'reviewed-1',
dateCreated: '',
project: ProjectFixture(),
data: {},
user,
},
Expand All @@ -115,7 +113,6 @@ describe('GroupActivity', function () {
activity: [
{
dateCreated: '',
project: ProjectFixture(),
type: GroupActivityType.SET_RESOLVED_IN_PULL_REQUEST,
id: 'pr-1',
data: {
Expand Down Expand Up @@ -149,7 +146,6 @@ describe('GroupActivity', function () {
user,
dateCreated: '2021-10-01T15:31:38.950115Z',
id: '117',
project: ProjectFixture(),
type: GroupActivityType.ASSIGNED,
},
],
Expand All @@ -171,7 +167,6 @@ describe('GroupActivity', function () {
rule: 'path:something/*.py #workflow',
user: UserFixture(),
},
project: ProjectFixture(),
dateCreated: '2021-10-01T15:31:38.950115Z',
id: '117',
type: GroupActivityType.ASSIGNED,
Expand All @@ -196,7 +191,6 @@ describe('GroupActivity', function () {
integration: 'slack',
user: UserFixture(),
},
project: ProjectFixture(),
dateCreated: '2021-10-01T15:31:38.950115Z',
id: '117',
type: GroupActivityType.ASSIGNED,
Expand All @@ -220,7 +214,6 @@ describe('GroupActivity', function () {
integration: 'suspectCommitter',
user: UserFixture(),
},
project: ProjectFixture(),
dateCreated: '1999-10-01T15:31:38.950115Z',
id: '117',
type: GroupActivityType.ASSIGNED,
Expand All @@ -247,7 +240,6 @@ describe('GroupActivity', function () {
integration: 'lottery',
user: UserFixture(),
},
project: ProjectFixture(),
dateCreated: '1999-10-01T15:31:38.950115Z',
id: '117',
type: GroupActivityType.ASSIGNED,
Expand All @@ -269,7 +261,6 @@ describe('GroupActivity', function () {
{
type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
id: '123',
project: ProjectFixture(),
dateCreated: '',
data: {
commit: {
Expand All @@ -296,7 +287,6 @@ describe('GroupActivity', function () {
{
type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
id: '123',
project: ProjectFixture(),
dateCreated: '',
data: {
commit: {
Expand Down Expand Up @@ -329,7 +319,6 @@ describe('GroupActivity', function () {
{
type: GroupActivityType.SET_RESOLVED_IN_COMMIT,
id: '123',
project: ProjectFixture(),
dateCreated: '',
data: {
commit: {
Expand Down Expand Up @@ -383,7 +372,6 @@ describe('GroupActivity', function () {
id: '123',
user: null,
type: GroupActivityType.ASSIGNED,
project: ProjectFixture(),
data: {
assignee: team.id,
assigneeType: 'team',
Expand Down Expand Up @@ -438,7 +426,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_IGNORED,
project: ProjectFixture(),
data: {
ignoreUntilEscalating: true,
},
Expand All @@ -457,7 +444,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_UNRESOLVED,
project: ProjectFixture(),
data: {
forecast: 200,
},
Expand All @@ -467,7 +453,6 @@ describe('GroupActivity', function () {
{
id: '124',
type: GroupActivityType.SET_ESCALATING,
project: ProjectFixture(),
data: {
forecast: 400,
},
Expand All @@ -491,7 +476,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_UNRESOLVED,
project: ProjectFixture(),
data: {
forecast: 1,
},
Expand All @@ -512,7 +496,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_UNRESOLVED,
project: ProjectFixture(),
data: {
integration_id: '1',
provider_key: 'jira',
Expand All @@ -533,7 +516,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_RESOLVED,
project: ProjectFixture(),
data: {
integration_id: '1',
provider_key: 'jira',
Expand All @@ -554,7 +536,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_ESCALATING,
project: ProjectFixture(),
data: {
expired_snooze: {
count: 400,
Expand All @@ -580,7 +561,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_ESCALATING,
project: ProjectFixture(),
data: {
expired_snooze: {
user_count: 1,
Expand All @@ -607,7 +587,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_ESCALATING,
project: ProjectFixture(),
data: {
expired_snooze: {
until: date,
Expand All @@ -633,7 +612,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_IGNORED,
project: ProjectFixture(),
data: {},
user: UserFixture(),
dateCreated,
Expand All @@ -650,7 +628,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_RESOLVED_IN_RELEASE,
project: ProjectFixture(),
data: {
version: '[email protected]',
},
Expand All @@ -671,7 +648,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_RESOLVED_IN_RELEASE,
project: ProjectFixture(),
data: {
current_release_version: '[email protected]',
},
Expand All @@ -693,7 +669,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_REGRESSION,
project: ProjectFixture(),
data: {},
dateCreated,
},
Expand All @@ -709,7 +684,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_REGRESSION,
project: ProjectFixture(),
data: {
version: '[email protected]',
},
Expand All @@ -729,7 +703,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_REGRESSION,
project: ProjectFixture(),
data: {
version: '[email protected]',
resolved_in_version: '[email protected]',
Expand All @@ -754,7 +727,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_REGRESSION,
project: ProjectFixture(),
data: {
version: 'frontend@abc1',
resolved_in_version: 'frontend@abc2',
Expand All @@ -779,7 +751,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_PRIORITY,
project: ProjectFixture(),
data: {
priority: PriorityLevel.HIGH,
reason: 'escalating',
Expand All @@ -800,7 +771,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.SET_PRIORITY,
project: ProjectFixture(),
data: {
priority: PriorityLevel.LOW,
reason: 'ongoing',
Expand All @@ -821,7 +791,6 @@ describe('GroupActivity', function () {
{
id: '123',
type: GroupActivityType.DELETED_ATTACHMENT,
project: ProjectFixture(),
data: {},
dateCreated,
user: UserFixture(),
Expand Down
4 changes: 0 additions & 4 deletions static/app/views/issueDetails/streamline/occurrenceSummary.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {EventFixture} from 'sentry-fixture/event';
import {GroupFixture} from 'sentry-fixture/group';
import {OrganizationFixture} from 'sentry-fixture/organization';
import {ProjectFixture} from 'sentry-fixture/project';

import {render, screen} from 'sentry-test/reactTestingLibrary';
import {resetMockDate, setMockDate} from 'sentry-test/utils';
Expand All @@ -16,7 +15,6 @@ import {OccurrenceSummary} from 'sentry/views/issueDetails/streamline/occurrence

describe('OccurrenceSummary', () => {
const organization = OrganizationFixture();
const project = ProjectFixture();

afterEach(() => {
resetMockDate();
Expand All @@ -41,14 +39,12 @@ describe('OccurrenceSummary', () => {
type: GroupActivityType.SET_RESOLVED,
dateCreated: '2025-01-02T11:00:00Z',
data: {},
project,
id: '2',
},
{
type: GroupActivityType.FIRST_SEEN,
dateCreated: '2025-01-01T11:00:00Z',
data: {},
project,
id: '1',
},
],
Expand Down
4 changes: 0 additions & 4 deletions static/app/views/issueDetails/streamline/sidebar/activitySection.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ describe('StreamlinedActivitySection', function () {
data: {text: 'Test Note'},
dateCreated: '2020-01-01T00:00:00',
user,
project,
},
],
project,
Expand Down Expand Up @@ -144,7 +143,6 @@ describe('StreamlinedActivitySection', function () {
data: {text: 'Group Test'},
dateCreated: '2020-01-01T00:00:00',
user,
project,
},
],
project,
Expand Down Expand Up @@ -191,7 +189,6 @@ describe('StreamlinedActivitySection', function () {
data: {text: 'Test Note'},
dateCreated: '2020-01-01T00:00:00',
user: UserFixture({id: '2'}),
project,
},
],
project,
Expand Down Expand Up @@ -276,7 +273,6 @@ describe('StreamlinedActivitySection', function () {
data: {text: 'Resolved'},
dateCreated: '2020-01-01T00:00:00',
user,
project,
});

const updatedActivityGroup = GroupFixture({
Expand Down
Loading
Loading