Skip to content

fix(search): Fix issue with tags name 'constructor' #92586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

fix(search): Fix issue with tags name 'constructor' #92586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions static/app/utils/fields/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2581,11 +2581,11 @@ export const getFieldDefinition = (
): FieldDefinition | null => {
switch (type) {
case 'replay':
if (key in REPLAY_FIELD_DEFINITIONS) {
if (REPLAY_FIELD_DEFINITIONS.hasOwnProperty(key)) {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
return REPLAY_FIELD_DEFINITIONS[key];
}
if (key in REPLAY_CLICK_FIELD_DEFINITIONS) {
if (REPLAY_CLICK_FIELD_DEFINITIONS.hasOwnProperty(key)) {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
return REPLAY_CLICK_FIELD_DEFINITIONS[key];
}
Expand All @@ -2595,7 +2595,7 @@ export const getFieldDefinition = (
}
return null;
case 'feedback':
if (key in FEEDBACK_FIELD_DEFINITIONS) {
if (FEEDBACK_FIELD_DEFINITIONS.hasOwnProperty(key)) {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
return FEEDBACK_FIELD_DEFINITIONS[key];
}
Expand Down Expand Up @@ -2625,7 +2625,7 @@ export const getFieldDefinition = (
return null;

case 'log':
if (key in LOG_FIELD_DEFINITIONS) {
if (LOG_FIELD_DEFINITIONS.hasOwnProperty(key)) {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
return LOG_FIELD_DEFINITIONS[key];
}
Expand All @@ -2644,8 +2644,11 @@ export const getFieldDefinition = (

case 'event':
default:
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
return EVENT_FIELD_DEFINITIONS[key] ?? null;
if (EVENT_FIELD_DEFINITIONS.hasOwnProperty(key)) {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
return EVENT_FIELD_DEFINITIONS[key];
}
return null;
}
};

Expand Down
Loading