Skip to content

feat(source-maps): Do not show pagination together with empty state #92287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025
Merged

feat(source-maps): Do not show pagination together with empty state #92287

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f26146e
feat(source-maps): Introduce new empty state copies and react-native …
priscilawebdev May 27, 2025
4b50b92
feat(source-maps): Do not show pagination together with empty state
priscilawebdev May 27, 2025
d46d285
Merge branch 'master' into priscila/feat/source-maps/do-not-display-p…
priscilawebdev Jun 2, 2025
7647295
Merge branch 'master' into priscila/feat/source-maps/do-not-display-p…
priscilawebdev Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 31 additions & 26 deletions static/app/views/settings/projectSourceMaps/sourceMapsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ export function SourceMapsList({location, router, project}: Props) {
deleteSourceMaps({bundleId: id, projectSlug: project.slug});
}}
docsLink={sourceMapsLinks.sourcemaps}
pageLinks={headers?.('Link') ?? ''}
/>
<Pagination pageLinks={headers?.('Link') ?? ''} />
</Fragment>
);
}
Expand Down Expand Up @@ -299,6 +299,7 @@ interface SourceMapUploadsListProps {
onClearSearch: () => void;
onDelete: (id: string) => void;
project: Project;
pageLinks?: string;
query?: string;
sourceMapUploads?: SourceMapUpload[];
}
Expand All @@ -311,6 +312,7 @@ function SourceMapUploadsList({
project,
query,
docsLink,
pageLinks,
}: SourceMapUploadsListProps) {
const organization = useOrganization();

Expand All @@ -337,31 +339,34 @@ function SourceMapUploadsList({
}

return (
<List>
{sourceMapUploads.map(sourceMapUpload => (
<Item key={sourceMapUpload.id}>
<ItemHeader>
<ItemTitle to={sourceMapUploadDetailLink(sourceMapUpload)}>
<IconUpload />
{tct('[date] ([fileCount] files)', {
date: <DateTime year date={sourceMapUpload.date} />,
fileCount: sourceMapUpload.fileCount,
})}
</ItemTitle>
<SourceMapUploadDeleteButton
onDelete={
sourceMapUpload.type === 'debugId'
? () => onDelete(sourceMapUpload.id)
: undefined
}
/>
</ItemHeader>
<ItemContent>
<SourceMapUploadDetails sourceMapUpload={sourceMapUpload} />
</ItemContent>
</Item>
))}
</List>
<Fragment>
<List>
{sourceMapUploads.map(sourceMapUpload => (
<Item key={sourceMapUpload.id}>
<ItemHeader>
<ItemTitle to={sourceMapUploadDetailLink(sourceMapUpload)}>
<IconUpload />
{tct('[date] ([fileCount] files)', {
date: <DateTime year date={sourceMapUpload.date} />,
fileCount: sourceMapUpload.fileCount,
})}
</ItemTitle>
<SourceMapUploadDeleteButton
onDelete={
sourceMapUpload.type === 'debugId'
? () => onDelete(sourceMapUpload.id)
: undefined
}
/>
</ItemHeader>
<ItemContent>
<SourceMapUploadDetails sourceMapUpload={sourceMapUpload} />
</ItemContent>
</Item>
))}
</List>
<Pagination pageLinks={pageLinks} />
</Fragment>
);
}

Expand Down
Loading