Skip to content

feat(nextjs-insights): fixed thresholds for p95 durations #92189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

feat(nextjs-insights): fixed thresholds for p95 durations #92189

merged 1 commit into from
Jun 3, 2025

Conversation

@shellmayr
Copy link
Member

@shellmayr shellmayr commented May 23, 2025 •
edited
Loading

  • Frontend data is more diverse than API responses and has more outliers, therefore there are many more cases where P95>2 x avg
  • Use fixed threshold to color the P95 in the PagesTable component
  • Thresholds are inspired by Web Vitals - 2500 and 4000 milliseconds for yellow & red

Before:
Screenshot 2025-05-23 at 11 12 08

After:
Screenshot 2025-05-23 at 11 11 49

@shellmayr shellmayr requested a review from a team as a code owner May 23, 2025 09:12
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 23, 2025
@codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #92189      +/-   ##
==========================================
- Coverage   86.80%   86.80%   -0.01%     
==========================================
  Files       10170    10170              
  Lines      583291   583290       -1     
  Branches    22596    22596              
==========================================
- Hits       506316   506315       -1     
  Misses      76523    76523              
  Partials      452      452

@shellmayr shellmayr merged commit cef3c21 into master Jun 3, 2025
79 of 89 checks passed
@shellmayr shellmayr deleted the shellmayr/tet-463-come-up-with-a-better-way-to-color-duration-outliers branch June 3, 2025 07:22
andrewshie-sentry pushed a commit that referenced this pull request Jun 3, 2025
@shellmayr @andrewshie-sentry
feat(nextjs-insights): fixed thresholds for p95 durations (#92189)
e220862
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@obostjancic obostjancic obostjancic approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shellmayr @obostjancic