-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(project-creation): Button should be busy until all mutations are complete #92183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
priscilawebdev
merged 11 commits into
master
from
priscila/fix/project-creation/disable-the-button-until-all-mutations-are-complete
Jun 3, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4437b77
ref(project-creation): Introduce useCreateProjectRules hook
priscilawebdev ccd66cb
fix(project-creation): Button should be busy until all mutations are …
priscilawebdev a7170ef
feedback
priscilawebdev c5dfc7a
feedback 2
priscilawebdev e970b69
Merge branch 'master' into priscila/ref/project-creation/introduce-us…
priscilawebdev 7f0ae30
it does not need to be tsx
priscilawebdev f6d89a9
Merge branch 'priscila/ref/project-creation/introduce-use-create-proj…
priscilawebdev 0b466fb
Merge branch 'priscila/ref/project-creation/introduce-use-create-proj…
priscilawebdev 3c6c200
it does not need to be tsx
priscilawebdev f377cbd
Merge branch 'master' into priscila/fix/project-creation/disable-the-…
priscilawebdev 6a9963c
fix conflict
priscilawebdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
static/app/components/onboarding/useCreateProjectAndRules.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import {useCreateProject} from 'sentry/components/onboarding/useCreateProject'; | ||
| import {useCreateProjectRules} from 'sentry/components/onboarding/useCreateProjectRules'; | ||
| import type {OnboardingSelectedSDK} from 'sentry/types/onboarding'; | ||
| import type {Project} from 'sentry/types/project'; | ||
| import {defined} from 'sentry/utils'; | ||
| import {useIsMutating, useMutation} from 'sentry/utils/queryClient'; | ||
| import type RequestError from 'sentry/utils/requestError/requestError'; | ||
| import type {useCreateNotificationAction} from 'sentry/views/projectInstall/issueAlertNotificationOptions'; | ||
| import type {RequestDataFragment} from 'sentry/views/projectInstall/issueAlertOptions'; | ||
|
|
||
| const MUTATION_KEY = 'create-project-and-rules'; | ||
|
|
||
| type Variables = { | ||
| alertRuleConfig: Partial<RequestDataFragment>; | ||
| createNotificationAction: ReturnType< | ||
| typeof useCreateNotificationAction | ||
| >['createNotificationAction']; | ||
| platform: OnboardingSelectedSDK; | ||
| projectName: string; | ||
| team?: string; | ||
| }; | ||
|
|
||
| type Response = { | ||
| project: Project; | ||
| ruleIds: string[]; | ||
| }; | ||
|
|
||
| export function useCreateProjectAndRules() { | ||
| const createProject = useCreateProject(); | ||
| const createProjectRules = useCreateProjectRules(); | ||
|
|
||
| return useMutation<Response, RequestError, Variables>({ | ||
| mutationKey: [MUTATION_KEY], | ||
| mutationFn: async ({ | ||
| projectName, | ||
| platform, | ||
| alertRuleConfig, | ||
| team, | ||
| createNotificationAction, | ||
| }) => { | ||
| const project = await createProject.mutateAsync({ | ||
| name: projectName, | ||
| platform, | ||
| default_rules: alertRuleConfig?.defaultRules ?? true, | ||
| firstTeamSlug: team, | ||
| }); | ||
|
|
||
| const customRulePromise = alertRuleConfig?.shouldCreateCustomRule | ||
| ? createProjectRules.mutateAsync({ | ||
| projectSlug: project.slug, | ||
| name: project.name, | ||
| conditions: alertRuleConfig?.conditions, | ||
| actions: alertRuleConfig?.actions, | ||
| actionMatch: alertRuleConfig?.actionMatch, | ||
| frequency: alertRuleConfig?.frequency, | ||
| }) | ||
| : undefined; | ||
|
|
||
| const notificationRulePromise = createNotificationAction({ | ||
| shouldCreateRule: alertRuleConfig?.shouldCreateRule, | ||
| name: project.name, | ||
| projectSlug: project.slug, | ||
| conditions: alertRuleConfig?.conditions, | ||
| actionMatch: alertRuleConfig?.actionMatch, | ||
| frequency: alertRuleConfig?.frequency, | ||
| }); | ||
|
|
||
| const rules = await Promise.all([customRulePromise, notificationRulePromise]); | ||
| const ruleIds = rules.filter(defined).map(rule => rule.id); | ||
|
|
||
| return {project, ruleIds}; | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| export function useIsCreatingProjectAndRules() { | ||
| return Boolean(useIsMutating({mutationKey: [MUTATION_KEY]})); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make a distinction between
busyanddisabledhere