Skip to content

Conversation

@vgrozdanic
Copy link
Member

Removes custom array lookup created for custom lookups related to span attribute metrics.

This is no longer used anywhere and there is no need to keep it in a codebase.

@vgrozdanic vgrozdanic requested a review from a team September 10, 2024 11:14
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 10, 2024
Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good one 😭 LGTM

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77234      +/-   ##
==========================================
- Coverage   78.14%   78.14%   -0.01%     
==========================================
  Files        6932     6931       -1     
  Lines      307795   307780      -15     
  Branches    50420    50420              
==========================================
- Hits       240539   240524      -15     
+ Misses      60855    60854       -1     
- Partials     6401     6402       +1     

Signed-off-by: Vjeran Grozdanic <[email protected]>
@vgrozdanic vgrozdanic force-pushed the vgrozdanic/chore/remove-custom-lookup branch from c55a23f to e08bb57 Compare September 10, 2024 11:54
@vgrozdanic vgrozdanic disabled auto-merge September 10, 2024 11:54
@vgrozdanic vgrozdanic merged commit 7abfaf6 into master Sep 10, 2024
@vgrozdanic vgrozdanic deleted the vgrozdanic/chore/remove-custom-lookup branch September 10, 2024 12:32
c298lee pushed a commit that referenced this pull request Sep 10, 2024
Removes custom array lookup created for custom lookups related to span
attribute metrics.

This is no longer used anywhere and there is no need to keep it in a
codebase.

Signed-off-by: Vjeran Grozdanic <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants