Skip to content

feat(feedback): add trace section to details, with analytics and FF #76858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 3, 2024
Merged

feat(feedback): add trace section to details, with analytics and FF #76858

merged 14 commits into from
Sep 3, 2024

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Sep 3, 2024 •
edited
Loading

Branched from #76372 (at first I thought this branch would be for analytics only, but now it replaces this PR)

Depends on #76867

Closes #68481

@aliu39 aliu39 requested a review from a team as a code owner September 3, 2024 16:53
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 3, 2024
@aliu39 aliu39 marked this pull request as draft September 3, 2024 16:54
ryan953
ryan953 reviewed Sep 3, 2024
View reviewed changes
ryan953
ryan953 reviewed Sep 3, 2024
View reviewed changes
@aliu39 aliu39 mentioned this pull request Sep 3, 2024
Merged
@aliu39 aliu39 marked this pull request as ready for review September 3, 2024 18:01
@aliu39 aliu39 changed the title feat(feedback): add trace data section to details, with metrics and a FF feat(feedback): add trace section to details, with analytics and FF Sep 3, 2024
aliu39 added a commit that referenced this pull request Sep 3, 2024
@aliu39
feat(feedback): add a FF for feedback details trace section (#76867)
ce598ca 
Used for #76858
@aliu39 aliu39 requested review from a team and ryan953 September 3, 2024 20:43
@aliu39 aliu39 mentioned this pull request Sep 3, 2024
Closed
@aliu39 aliu39 merged commit c8173e9 into master Sep 3, 2024
@aliu39 aliu39 deleted the aliu/feedback-trace-metric branch September 3, 2024 21:45
This was referenced Sep 3, 2024
Closed
Merged
aliu39 added a commit that referenced this pull request Sep 5, 2024
@aliu39
fix(feedback): set api_expose=True for user-feedback-trace-section FF…
69ca4cc 
… registration (#76983)

Attempt to expose the FF for Sentry frontend. Used in
#76858
@aliu39 aliu39 mentioned this pull request Sep 9, 2024
Merged
aliu39 added a commit that referenced this pull request Sep 9, 2024
@aliu39
fix(feedback): fix analytics calls for new trace section (#77182)
9c15063 
ref #76858
c298lee pushed a commit that referenced this pull request Sep 10, 2024
@aliu39 @c298lee
fix(feedback): fix analytics calls for new trace section (#77182)
4f92776 
ref #76858
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@michellewzhang michellewzhang michellewzhang approved these changes

@ryan953 ryan953 Awaiting requested review from ryan953

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[User Feedback] - Issue Trace Timeline

4 participants

@aliu39 @ryan953 @michellewzhang