Skip to content

fix(custom-views): Fix infinite rerendering upon unsaved changes #76672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2024
Merged

fix(custom-views): Fix infinite rerendering upon unsaved changes #76672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31ed81b
Remove unncessary dependencies from useEffect
Aug 28, 2024
0fc8cba
Remove tabliststate from dependency array
Aug 28, 2024
6908eee
Add error boundary
Aug 28, 2024
82309e9
Update comment
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions static/app/views/issueList/customViewsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ function CustomViewsIssueListHeaderTabsContent({
[organization.slug, updateViews]
);

// This insane useEffect ensures that the correct tab is selected when the page loads and url updates
// This insane useEffect ensures that the correct tab is selected when the url updates
useEffect(() => {
// If no query, sort, or viewId is present, set the first tab as the selected tab, update query accordingly
if (!query && !sort && !viewId) {
Expand Down Expand Up @@ -241,16 +241,8 @@ function CustomViewsIssueListHeaderTabsContent({
tabListState?.setSelectedKey('temporary-tab');
return;
}
}, [
tabListState,
draggableTabs,
navigate,
organization.slug,
query,
queryParams,
sort,
viewId,
]);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [navigate, organization.slug, query, sort, viewId]);

// Update local tabs when new views are received from mutation request
useEffect(() => {
Expand Down
15 changes: 9 additions & 6 deletions static/app/views/issueList/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {addMessage} from 'sentry/actionCreators/indicator';
import {fetchOrgMembers, indexMembersByProject} from 'sentry/actionCreators/members';
import {fetchTagValues, loadOrganizationTags} from 'sentry/actionCreators/tags';
import type {Client} from 'sentry/api';
import ErrorBoundary from 'sentry/components/errorBoundary';
import HookOrDefault from 'sentry/components/hookOrDefault';
import * as Layout from 'sentry/components/layouts/thirds';
import LoadingIndicator from 'sentry/components/loadingIndicator';
Expand Down Expand Up @@ -1226,12 +1227,14 @@ class IssueListOverview extends Component<Props, State> {
return (
<Layout.Page>
{organization.features.includes('issue-stream-custom-views') ? (
<CustomViewsIssueListHeader
organization={organization}
queryCounts={queryCounts}
router={router}
selectedProjectIds={selection.projects}
/>
<ErrorBoundary message={'Failed to load custom tabs'}>
<CustomViewsIssueListHeader
organization={organization}
queryCounts={queryCounts}
router={router}
selectedProjectIds={selection.projects}
/>
</ErrorBoundary>
) : (
<IssueListHeader
organization={organization}
Expand Down