feat(replay): Calculate hydration diff timestamps based on related hydration breadcrumbs #73095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dration breadcrumbs
github-actions
bot
added
the
Scope: Frontend
ryan953
changed the title
Bundle ReportChanges will decrease total bundle size by 1.33kB ⬇️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73095 +/- ##
==========================================
+ Coverage 70.83% 77.98% +7.15%
==========================================
Files 6629 6619 -10
Lines 295890 295061 -829
Branches 50965 50830 -135
==========================================
+ Hits 209585 230100 +20515
+ Misses 79293 58653 -20640
+ Partials 7012 6308 -704
|
ryan953
changed the title
michellewzhang
approved these changes
Jun 21, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 2nd try at #72561
The original was reverted in 986296c because of some errors that popped up:
The difference now is that I've improved the types to include
data.mutations.next. The real but though was that before, inbreadcrumbItem.tsx, we were doing the left/right timestamp math only for crumbs that have that mutations.next field...That problem is fixed now because we're checking the crumb type first, then defer to the new
<CrumbHydrationButton>which will get the offsets and render all at once.Without that fix, we were basically trying to get the left/right offsets for any breadcrumb type, which would easily explode.
Related to #70199