feat: Update Sentry SDK to 8.0.0-beta.5 #68520

mydea · 2024-04-09T08:52:44Z

Updates the SDK to the v8 beta release.

github-actions · 2024-04-09T08:53:03Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

codecov · 2024-04-09T08:59:11Z

Bundle Report

Changes will decrease total bundle size by 8.57kB ⬇️

Bundle name	Size	Change
app-webpack-bundle-array-push	26.51MB	8.57kB ⬇️

static/app/bootstrap/initializeSdk.tsx

AbhiPrasad · 2024-04-24T15:16:51Z

We can bump to https://github.com/getsentry/sentry-javascript/releases/tag/8.0.0-beta.4 now!

jest.config.ts

static/app/components/feedback/widget/useFeedbackWidget.tsx

ryan953 · 2024-04-29T19:56:44Z

static/app/components/feedback/widget/useFeedbackWidget.tsx

-        };
+        // TODO: Remove this after we update to 8.0.0-beta.5
+        // @ts-expect-error This is wrongly typed in the current version...
+        return feedback.attachTo(buttonRef.current, options);


This is working ✅

static/app/components/feedback/widget/useFeedbackWidget.tsx

ryan953 · 2024-04-30T18:41:41Z

static/app/components/feedback/widget/useFeedbackWidget.tsx

      const widget = feedback.createWidget(options);
      return () => {
-        feedback.removeWidget(widget);
+        widget.removeFromDom();


This is working now with beta 5

example from the Releases page

ryan953

✅ for Replay & Feedback

scttcper · 2024-05-01T16:25:36Z

yarn.lock

+  dependencies:
+    "@types/pg" "*"
+
+"@types/pg@*":


kinda gross these all get pulled in

note that this is only pulled in because of @sentry/node, it would not be there for @sentry/react. The downside of going all-in on OTEL 😬

evanpurkhiser · 2024-05-01T16:31:22Z

yarn.lock

+    "@opentelemetry/instrumentation-connect" "0.35.0"
+    "@opentelemetry/instrumentation-express" "0.35.0"
+    "@opentelemetry/instrumentation-fastify" "0.35.0"
+    "@opentelemetry/instrumentation-graphql" "0.39.0"
+    "@opentelemetry/instrumentation-hapi" "0.36.0"
+    "@opentelemetry/instrumentation-http" "0.48.0"
+    "@opentelemetry/instrumentation-koa" "0.39.0"
+    "@opentelemetry/instrumentation-mongodb" "0.39.0"
+    "@opentelemetry/instrumentation-mongoose" "0.37.0"
+    "@opentelemetry/instrumentation-mysql" "0.37.0"
+    "@opentelemetry/instrumentation-mysql2" "0.37.0"
+    "@opentelemetry/instrumentation-nestjs-core" "0.36.0"
+    "@opentelemetry/instrumentation-pg" "0.40.0"


Would it be possible to make these something more like peer dependencies?

Is there an ongoing discussion anywhere about this? I would expect people (our customers) to be unhappy about how many new things we're pulling in

This is basically the tradeoff we have for auto-instrumentation with minimal setup. Without this, users would need to manually install a bunch of stuff 😬 so it's something we are aware of. If we find this to become a problem we'll look into this more.

mydea self-assigned this Apr 9, 2024

github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 9, 2024

vercel bot deployed to Preview April 9, 2024 08:54 View deployment

mydea changed the title ~~build: Update Sentry SDK to 8.0.0-alpha.9~~ build: Update Sentry SDK to 8.0.0-beta.2 Apr 17, 2024

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from 49e0e43 to ce50d27 Compare April 17, 2024 14:51

vercel bot deployed to Preview April 17, 2024 14:54 View deployment

codecovdesign mentioned this pull request Apr 17, 2024

Bundle report showing in pr comment - in-app shows missing head error codecov/engineering-team#1597

Closed

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from ce50d27 to 47c655c Compare April 18, 2024 07:01

vercel bot deployed to Preview April 18, 2024 07:05 View deployment

AbhiPrasad mentioned this pull request Apr 22, 2024

Investigate long running traces originating from Sentry frontend #69457

Closed

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from 47c655c to 54d5cff Compare April 24, 2024 13:34

vercel bot deployed to Preview April 24, 2024 13:37 View deployment

mydea changed the title ~~build: Update Sentry SDK to 8.0.0-beta.2~~ build: Update Sentry SDK to 8.0.0-beta.3 Apr 24, 2024

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from 54d5cff to b9f8ef6 Compare April 24, 2024 14:37

mydea commented Apr 24, 2024

View reviewed changes

static/app/bootstrap/initializeSdk.tsx Show resolved Hide resolved

mydea commented Apr 24, 2024

View reviewed changes

static/app/bootstrap/initializeSdk.tsx Show resolved Hide resolved

vercel bot deployed to Preview April 24, 2024 14:41 View deployment

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from f9701fe to 371cbe7 Compare April 25, 2024 12:38

mydea changed the title ~~build: Update Sentry SDK to 8.0.0-beta.3~~ build: Update Sentry SDK to 8.0.0-beta.4 Apr 25, 2024

vercel bot deployed to Preview April 25, 2024 12:40 View deployment

vercel bot deployed to Preview April 25, 2024 13:01 View deployment

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from 431de83 to b262614 Compare April 25, 2024 14:11

vercel bot deployed to Preview April 25, 2024 14:13 View deployment

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from b262614 to 5c445b5 Compare April 26, 2024 07:44

vercel bot deployed to Preview April 26, 2024 07:46 View deployment

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from 5c445b5 to 7a365a6 Compare April 26, 2024 11:05

vercel bot deployed to Preview April 26, 2024 11:30 View deployment

vercel bot deployed to Preview April 26, 2024 12:06 View deployment

billyvg reviewed Apr 26, 2024

View reviewed changes

jest.config.ts Outdated Show resolved Hide resolved

ryan953 reviewed Apr 29, 2024

View reviewed changes

static/app/components/feedback/widget/useFeedbackWidget.tsx Outdated Show resolved Hide resolved

ryan953 reviewed Apr 29, 2024

View reviewed changes

static/app/components/feedback/widget/useFeedbackWidget.tsx Outdated Show resolved Hide resolved

mydea changed the title ~~feat: Update Sentry SDK to 8.0.0-beta.4~~ feat: Update Sentry SDK to 8.0.0-beta.5 Apr 30, 2024

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from c0e041c to ef70c31 Compare April 30, 2024 10:25

vercel bot deployed to Preview April 30, 2024 10:30 View deployment

vercel bot deployed to Preview April 30, 2024 10:55 View deployment

ryan953 reviewed Apr 30, 2024

View reviewed changes

ryan953 approved these changes Apr 30, 2024

View reviewed changes

scttcper reviewed May 1, 2024

View reviewed changes

evanpurkhiser reviewed May 1, 2024

View reviewed changes

mydea and others added 9 commits May 2, 2024 10:22

build: Update Sentry SDK to 8.0.0-beta.4

1d85f2c

fix feedback type

adaba91

pr fixes

13d4b32

bump spotlight

e288bba

fix beta.5

34ce0fb

fix jest config

63c66bc

revert jest config

a1baa82

fix(chartcuterie): Skip capture exception if locale not set

1c4a136

cleanup

4f68800

mydea force-pushed the fn/bump-sentry-sdk-alpha branch from afc851b to 4f68800 Compare May 2, 2024 08:22

vercel bot deployed to Preview May 2, 2024 08:24 View deployment

fix after rebase

34243dd

vercel bot deployed to Preview May 2, 2024 09:13 View deployment

mydea merged commit 5bff6b7 into master May 2, 2024

mydea deleted the fn/bump-sentry-sdk-alpha branch May 2, 2024 09:58

github-actions bot locked and limited conversation to collaborators May 17, 2024

Uh oh!

feat: Update Sentry SDK to 8.0.0-beta.5 #68520

feat: Update Sentry SDK to 8.0.0-beta.5 #68520

Uh oh!

Conversation

mydea commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2024

Uh oh!

codecov bot commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

Uh oh!

Uh oh!

AbhiPrasad commented Apr 24, 2024

Uh oh!

Uh oh!

Uh oh!

ryan953 Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ryan953 Apr 30, 2024

Choose a reason for hiding this comment

Uh oh!

ryan953 left a comment

Choose a reason for hiding this comment

Uh oh!

scttcper May 1, 2024

Choose a reason for hiding this comment

Uh oh!

mydea May 2, 2024

Choose a reason for hiding this comment

Uh oh!

evanpurkhiser May 1, 2024

Choose a reason for hiding this comment

Uh oh!

mydea May 2, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mydea commented Apr 9, 2024 •

edited

Loading

codecov bot commented Apr 9, 2024 •

edited

Loading