fix(wizard) Fix possibly unbound variable in setup wizard #59934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been a few UnboundLocalError events captured which wouldn't happen with this approach. Fixes SENTRY-180Q
github-actions
bot
added
the
Scope: Backend
corps
reviewed
Nov 14, 2023
| return render_to_response("sentry/setup-wizard.html", context, request) | ||
|
|
||
|
|
||
| def get_token(mappings: List[OrganizationMapping], user: User): |
Contributor
There was a problem hiding this comment.
This typing can "just" be RpcUser now that request.user is never a User.
corps
approved these changes
Nov 14, 2023
Comment on lines
113
to
119
| for region_name, region_data in region_data_map.items(): | ||
| for key in region_data["keys"]: | ||
| serialized_key = { | ||
| "dsn": {"public": key.dsn_public}, | ||
| "isActive": key.is_active, | ||
| } | ||
| keys_map[key.project_id].append(serialized_key) |
Member
There was a problem hiding this comment.
I was looking through this code earlier after seeing the issue. It looks like we can potentially flatten/combine a few of these loops that iterate over region_data_map. Is there any reason not to just inline this logic with the original region_data["keys"] set logic on line 97?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #59934 +/- ##
==========================================
- Coverage 80.77% 80.75% -0.02%
==========================================
Files 5176 5179 +3
Lines 227273 227387 +114
Branches 38252 38258 +6
==========================================
+ Hits 183580 183630 +50
- Misses 38119 38167 +48
- Partials 5574 5590 +16
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few UnboundLocalError events captured which wouldn't happen with this approach.
Fixes SENTRY-180Q