Skip to content

fix(email): Make uploaded avatar look better #59547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(email): Make uploaded avatar look better #59547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sentry/notifications/notifications/activity/note.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from django.utils.html import format_html
from django.utils.safestring import SafeString

from sentry.notifications.utils.avatar import avatar_as_html
from sentry.notifications.utils.avatar import avatar_as_html, get_user_avatar_url
from sentry.services.hybrid_cloud.actor import RpcActor
from sentry.types.integrations import ExternalProviders

Expand Down Expand Up @@ -46,6 +46,11 @@ def description_as_html(self, description: str, params: Mapping[str, Any]) -> Sa
and want the avatar on it's own rather than bundled with the author's display name
because the display name is already shown in the notification title."""
fmt = '<span class="avatar-container">{}</span>'

if self.user:
if self.user.get_avatar_type() == "upload":
return format_html(
'<img class="avatar" src="{}">', get_user_avatar_url(self.user, 48)
)
return format_html(fmt, avatar_as_html(self.user, 48))
return format_html(description)