Skip to content

Conversation

@azaslavsky
Copy link
Contributor

@azaslavsky azaslavsky commented Oct 18, 2023

This finishes out the work started in #57740 and enables imports over RPC as well. Like that PR, imports are already done on a sequential, per model basis, so this change just consists of moving every such call across an RPC boundary.

This is a second attempt at landing this PR, with fewer tests tested in both modes.

This finishes out the work started in #57740 and enables imports over
RPC as well. Like that PR, imports are already done on a sequential, per
model basis, so this change just consists of moving every such call
across an RPC boundary.

This is a second attempt at landing this PR, with fewer tests tested in
both modes.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 18, 2023
@azaslavsky azaslavsky marked this pull request as ready for review October 18, 2023 23:46
@azaslavsky azaslavsky requested review from a team as code owners October 18, 2023 23:46
@azaslavsky azaslavsky requested a review from a team October 18, 2023 23:46
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #58412 (c2f2414) into master (e82988b) will increase coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 91.81%.

@@            Coverage Diff             @@
##           master   #58412      +/-   ##
==========================================
+ Coverage   79.08%   79.11%   +0.02%     
==========================================
  Files        5144     5144              
  Lines      223978   224118     +140     
  Branches    37714    37741      +27     
==========================================
+ Hits       177139   177304     +165     
+ Misses      41163    41133      -30     
- Partials     5676     5681       +5     
Files Coverage Δ
src/sentry/backup/dependencies.py 89.92% <100.00%> (+0.07%) ⬆️
src/sentry/backup/exports.py 81.81% <100.00%> (-1.11%) ⬇️
...entry/services/hybrid_cloud/import_export/model.py 97.36% <100.00%> (+1.84%) ⬆️
src/sentry/testutils/helpers/backups.py 98.46% <100.00%> (+8.17%) ⬆️
static/app/components/tabs/index.tsx 100.00% <ø> (ø)
...try/services/hybrid_cloud/import_export/service.py 92.10% <94.44%> (+1.62%) ⬆️
src/sentry/backup/imports.py 91.20% <93.75%> (+2.23%) ⬆️
src/sentry/utils/env.py 81.81% <77.77%> (-18.19%) ⬇️
...sentry/services/hybrid_cloud/import_export/impl.py 87.42% <83.54%> (-4.25%) ⬇️

... and 9 files with indirect coverage changes

@azaslavsky azaslavsky merged commit 00fb8dd into master Oct 19, 2023
@azaslavsky azaslavsky deleted the azaslavsky/backup/import_rpc_2 branch October 19, 2023 04:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants