fix(notifications): hide provider option for weekly reports and fix org specific settings #57992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scefali
changed the title
snigdhas
reviewed
Oct 12, 2023
| > | ||
| <BottomJsonForm fields={this.getProviderFields()} /> | ||
| </Form> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
Does this handle saving the data correctly? As in, will this set NotificationSettingProvider for email?
Contributor
Author
There was a problem hiding this comment.
@snigdhas Yes, I verified. It all goes to the control silo so it's fine. I think the problem is that to get the projects you have to pick the region silo but not an issue for the organization which has replication in the control silo.
scttcper
reviewed
Oct 13, 2023
| handleOrgChange={handleOrgChange} | ||
| /> | ||
| ) : ( | ||
| t('Settings for Organizations') |
scttcper
approved these changes
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only support the email provider for weekly reports. Also, we can hide the dropdown for organization for deploy notifications.
Before:
After:
