-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: no more zookeeper #55742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no more zookeeper #55742
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
26dd4fd to
04c71ac
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #55742 +/- ##
=======================================
Coverage 78.92% 78.93%
=======================================
Files 5118 5118
Lines 220800 220802 +2
Branches 37388 37388
=======================================
+ Hits 174272 174282 +10
+ Misses 40895 40890 -5
+ Partials 5633 5630 -3
|
|
@joshuarli we should keep zookeeper in this patch, then fix getsentry, then remove it in a followup patch -- that way we don't disrupt developers |
asottile-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Moving to this newer version of kafka where zookeeper is deprecated and can run in a zookeeper-less mode is good: