Skip to content

Conversation

@joshuarli
Copy link
Member

@joshuarli joshuarli commented Sep 6, 2023

Moving to this newer version of kafka where zookeeper is deprecated and can run in a zookeeper-less mode is good:

  • less moving parts - one java container instead of two - presumably less resource intensive overall
  • CI and local versions can match again as upstream publishes both amd64 and aarch64 docker images
  • less complexity (no more waiting for zookeeper startup, networking is less complicated as we don't need to differentiate between sentry_zookeeper and localhost, etc.)

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Sep 6, 2023
@getsentry getsentry deleted a comment from github-actions bot Sep 6, 2023
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 9:32pm

@joshuarli joshuarli marked this pull request as ready for review October 2, 2023 21:30
@joshuarli joshuarli requested a review from a team as a code owner October 2, 2023 21:30
@getsentry getsentry deleted a comment from codecov bot Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #55742 (b99dd2c) into master (dcac7bb) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #55742   +/-   ##
=======================================
  Coverage   78.92%   78.93%           
=======================================
  Files        5118     5118           
  Lines      220800   220802    +2     
  Branches    37388    37388           
=======================================
+ Hits       174272   174282   +10     
+ Misses      40895    40890    -5     
+ Partials     5633     5630    -3     
Files Coverage Δ
src/sentry/conf/server.py 89.79% <ø> (ø)

... and 7 files with indirect coverage changes

@asottile-sentry
Copy link
Contributor

@joshuarli we should keep zookeeper in this patch, then fix getsentry, then remove it in a followup patch -- that way we don't disrupt developers

Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuarli joshuarli merged commit 9ed7f93 into master Oct 3, 2023
@joshuarli joshuarli deleted the kafka-no-zookeeper branch October 3, 2023 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants