move commit fetching to celery task #5275
Conversation
macqueen
force-pushed
the
celery-commits
branch
from
769956a to
2104ec3
Compare
| CELERY_QUEUES = [ | ||
| Queue('alerts', routing_key='alerts'), | ||
| Queue('auth', routing_key='auth'), | ||
| Queue('commits', routing_key='commits'), |
There was a problem hiding this comment.
@JTCunning these is going to get picked up by a worker-glob worker, right?
We also might need to explicitly add the queue to federation. I don't fully remember how that works. (Should prob document)
There was a problem hiding this comment.
It will get picked up there, and I'm not completely sure we need to add it to the federation list unless we expect this to be heavily populated.
https://github.com/getsentry/ops/blob/master/cookbooks/getsentry/recipes/queue.rb#L86
| kwargs={ | ||
| 'release_id': self.id, | ||
| 'user_id': user.id, | ||
| 'refs': refs, |
There was a problem hiding this comment.
How large are these ref objects? Can we slim them down to just the bits we need? It seems we only use commit, repository, and previousCommit. Is there a lot of other junk piled on here?
If not, we're good. Otherwise, I'd want to slim this down before throwing into the queue.
There was a problem hiding this comment.
| kwargs={ | ||
| 'release_id': self.id, | ||
| 'user_id': user.id, | ||
| 'refs': refs, |
cc @benvinegar @kjlundsgaard @ckj @MaxBittker
#nochanges