fix(user-feedback-dialog): Set header on user feedback dialog embed response #51138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Jun 20, 2023
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
could add a test to tests/sentry/web/frontend/test_error_page_embed.py to confirm behavior but looks good to me!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51138 +/- ##
==========================================
+ Coverage 79.04% 81.23% +2.18%
==========================================
Files 4886 4895 +9
Lines 204852 205385 +533
Branches 11123 11123
==========================================
+ Hits 161929 166847 +4918
+ Misses 42677 38292 -4385
Partials 246 246
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently some cors policy headers like
Cross-Origin-Opener-Policy: same-originandCross-Origin-Embedder-Policy: require-corpcause requests to our user report dialog template to fail.This PR adds a
Access-Control-Allow-Origin: *header to the response to always allow access to the resource, regardless of the policy. This should be safe since the resource is not behind auth or anything user-specific.Would love input from some more CORS-savvy people though.
Fixes #49535