Skip to content

Conversation

@malwilley
Copy link
Member

Closes #50230

The goal of this PR is to add:

  1. Syntax highlighting for the graphql query
  2. Add a line highlight when there is a graphql error that points to the query

You can test this with these sample events: 1, 2

Before:

CleanShot 2023-06-12 at 12 20 52

After (shown here with some mocked data since the events in sentry-sdks are not formatted):

CleanShot 2023-06-12 at 12 19 08

@malwilley malwilley requested a review from vuluongj20 June 12, 2023 19:25
@malwilley malwilley requested a review from a team as a code owner June 12, 2023 19:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2023
@malwilley malwilley force-pushed the malwilley/feat/graphql-request-body branch from 6f1466b to 2ec7bca Compare June 12, 2023 19:25
Copy link
Member Author

@malwilley malwilley Jun 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuluongj20 was hoping you could review the css changes here

@malwilley malwilley enabled auto-merge (squash) June 13, 2023 18:21
@malwilley malwilley merged commit 0b85048 into master Jun 13, 2023
@malwilley malwilley deleted the malwilley/feat/graphql-request-body branch June 13, 2023 18:37
@marandaneto
Copy link
Contributor

Thank you @malwilley

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQL syntax highlighting for Request and Response bodies

4 participants