fix(crons): Pass environment to edit monitor page #47435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Apr 15, 2023
Member
evanpurkhiser
left a comment
evanpurkhiser
left a comment
There was a problem hiding this comment.
it's definitely gross, but let's make the product work and make this page better once we start working on new designs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving the edit monitor page, we are redirected to the monitor details page with unfortunately no monitor environment in the URL. This causes us to query for no monitor environments from the backend and making the frontend believe that the monitor has not received any checkins. Hack in the environment through the URL to prevent this for now.