Skip to content

Conversation

@mattjohnsonpint
Copy link
Contributor

Small nitpick. Consider an event such as:

{
  "type": "error",
  "exception": {
    "values": [
      {
        "type": "Exception",
        "mechanism": {
          "type": "some_mechanism_type",
          "help_link": "https://foo.bar",
          "description": "This is a human-readable description of some mechanism type."
        }
      }
    ]
  }
}

Within the mechanism, type is required, but help_link and description are optional.

When either are provided, currently the placement of the link or hover card is on the name of the pill (the word mechanism).

  • Example 1:
    image

  • Example 2:
    image

It should instead be on the value of the pill (which corresponds to the type).

  • Example 1:
    image

  • Example 2:
    image

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner April 10, 2023 23:32
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 10, 2023
@mattjohnsonpint mattjohnsonpint changed the title Fix mechansim type link placement fix(ui): Fix mechansim type link placement Apr 10, 2023
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) April 10, 2023 23:42
@mattjohnsonpint mattjohnsonpint merged commit 2e2deb3 into master Apr 10, 2023
@mattjohnsonpint mattjohnsonpint deleted the fix/mechanism-description branch April 10, 2023 23:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants