Skip to content

fix(crons): Correctly display schedule errors #47124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023
Merged

fix(crons): Correctly display schedule errors #47124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion static/app/views/monitors/components/monitorForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ type TransformedData = {
config?: Partial<MonitorConfig>;
};

/**
* Transform config field values into the config object
*/
function transformData(_data: Record<string, any>, model: FormModel) {
return model.fields.toJSON().reduce<TransformedData>((data, [k, v]) => {
// We're only concerned with transforming the config
Expand Down Expand Up @@ -95,14 +98,31 @@ function transformData(_data: Record<string, any>, model: FormModel) {
}, {});
}

/**
* Transform config field errors from the error response
*/
function mapFormErrors(responseJson?: any) {
if (responseJson.config === undefined) {
return responseJson;
}

// Bring nested config entries to the top
const {config, ...responseRest} = responseJson;
const configErrors = Object.fromEntries(
Object.entries(config).map(([key, value]) => [`config.${key}`, value])
);

return {...responseRest, ...configErrors};
}

function MonitorForm({
monitor,
submitLabel,
apiEndpoint,
apiMethod,
onSubmitSuccess,
}: Props) {
const form = useRef(new FormModel({transformData}));
const form = useRef(new FormModel({transformData, mapFormErrors}));
const {projects} = useProjects();
const {selection} = usePageFilters();
const [crontabInput, setCrontabInput] = useState(
Expand Down