fix(crons) Add missing CSRF exemption for checkin endpoint #45694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method delegator also needs to be able to apply CSRF exemption so that monitors can accept a DSN auth. There is an existing test for this authentication mode but it doesn't have issues with CSRF and I don't yet know why. Refs #45690
github-actions
bot
added
the
Scope: Backend
davidenwang
approved these changes
Mar 13, 2023
mitsuhiko
approved these changes
Mar 13, 2023
markstory
pushed a commit
that referenced
this pull request
Mar 13, 2023
davidenwang
pushed a commit
that referenced
this pull request
Mar 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method delegator also needs to be able to apply CSRF exemption so that monitors can accept a DSN auth. There is an existing test for this authentication mode but it doesn't have issues with CSRF and I don't yet know why.
Refs #45690