feat(CapMan): QueryBuilders + Search tenant_ids
#45505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
…/querybuilder_tenant_ids
rahul-kumar-saini
changed the title
tenant_idstenant_ids
volokluev
reviewed
Mar 9, 2023
Member
volokluev
left a comment
volokluev
left a comment
There was a problem hiding this comment.
it seems like these don't have referrers attached to them. How are they populated?
| Select a field, define a date range, and group or filter by columns. | ||
| """ | ||
| with self.handle_query_errors(): | ||
| tenant_ids = {"organization_id": organization.id} |
Member
There was a problem hiding this comment.
does the referrer get injected somewhere else?
Contributor
Author
There was a problem hiding this comment.
Since referrer is passed to Snuba in every request, I've updated the Snuba query functions in utils/snuba.py to at least add the referrer per request into tenant ids.
Eg:
sentry/src/sentry/utils/snuba.py
Lines 719 to 721 in b921766
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
QueryBuilderobjects now contain org ID intenant_idsfor their Snuba Requeststenant_idsto Snuba #44788 for more context