-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(CapMan): Tagstore Org IDs passed to Snuba #45454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5e5f441
modelid:300, modelid:100, legacy queries
rahul-kumar-saini 1e01ace
get_release_tags + group serializer
rahul-kumar-saini b29da14
Add referrer to tenant ids at query level instead
rahul-kumar-saini 95cb902
remove hardcoded referrer
rahul-kumar-saini 446bfeb
undo referrer abstractions
rahul-kumar-saini fc5c3db
get_tag_key and get_tag_keys_for_projects
rahul-kumar-saini d0c93a2
Merge branch 'master' into rahul/feat/tagstore_tenant_ids
rahul-kumar-saini 8296b00
get_tag_keys and get_group_tag_keys
rahul-kumar-saini 977aa38
get_groups_user_counts
rahul-kumar-saini aee4d56
get_group_list_tag_value
rahul-kumar-saini c86cc61
rest of group serializers
rahul-kumar-saini 28e6c96
get_tag_value and get_tag_values
rahul-kumar-saini 34f591b
more random unused? getters
rahul-kumar-saini 379f9e5
more paginators
rahul-kumar-saini 309757a
finished
rahul-kumar-saini 50b6cd5
finished
rahul-kumar-saini 932eaed
merge conflict
rahul-kumar-saini 90e95ba
kwargs bug
rahul-kumar-saini 81a3e32
kwargs bug fixed fr
rahul-kumar-saini 5f757d7
undo swap
rahul-kumar-saini b25eb1e
Fix query_builder
rahul-kumar-saini 0d8fc1b
remove dead code
rahul-kumar-saini f44e929
undo builder change for now
rahul-kumar-saini 847409c
get_tag_values special case fix
rahul-kumar-saini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that we preload group projects here
sentry/src/sentry/api/serializers/models/group.py
Line 214 in c8bbb69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm new to Django, are you saying I'm causing an extra query by doing
.project.organization_id? How can I avoid this if so?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just noting for anyone else reading that it won't cause any extra load