Skip to content

fix(query-subscriptions-consumer): Revert CLI changes to query subscriptions consumer #45230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2023
Merged

fix(query-subscriptions-consumer): Revert CLI changes to query subscriptions consumer #45230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64288fe
fix(query-subscriptions-consumer): Accidentally changed the default/h…
lynnagara Mar 1, 2023
4e0e036
revert help text
lynnagara Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/sentry/runner/commands/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,13 @@ def cron(**options):
"--commit-batch-size",
default=1000,
type=int,
help="How many messages to process (may or may not result in an enqueued task) before committing offsets.",
help="Deprecated. Remove once no longer passed in production.",
)
@click.option(
"--commit-batch-timeout-ms",
default=5000,
type=int,
help="Time (in milliseconds) to wait before closing current batch and committing offsets.",
help="Deprecated. Remove once no longer passed in production.",
)
@click.option(
"--concurrency",
Expand Down Expand Up @@ -405,15 +405,15 @@ def post_process_forwarder(**options):
@click.option("--topic", default=None, help="Topic to get subscription updates from.")
@click.option(
"--commit-batch-size",
default=1000,
default=100,
type=int,
help="Deprecated. Remove once no longer passed in production.",
help="How many messages to process before committing offsets.",
)
@click.option(
"--commit-batch-timeout-ms",
default=5000,
type=int,
help="Deprecated. Remove once no longer passed in production.",
help="Time (in milliseconds) to wait before closing current batch and committing offsets.",
)
@click.option(
"--initial-offset-reset",
Expand Down