Skip to content

fix(alerts): Center table items on alert history page #45226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(alerts): Center table items on alert history page #45226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions static/app/views/alerts/list/incidents/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,10 @@ function IncidentsListContainer(props: Props) {

const StyledPanelTable = styled(PanelTable)`
font-size: ${p => p.theme.fontSizeMedium};

& > div {
padding: ${space(1.5)} ${space(2)};
}
`;

const StyledAlert = styled(Alert)`
Expand Down
25 changes: 15 additions & 10 deletions static/app/views/alerts/list/incidents/row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ function AlertListRow({incident, projectsLoaded, projects, organization}: Props)

return (
<ErrorBoundary>
<Title data-test-id="alert-title">
<Link to={alertLink}>{incident.title}</Link>
</Title>
<FlexCenter>
<Title data-test-id="alert-title">
<Link to={alertLink}>{incident.title}</Link>
</Title>
</FlexCenter>

<NoWrapNumeric>
{getDynamicText({
Expand All @@ -66,13 +68,15 @@ function AlertListRow({incident, projectsLoaded, projects, organization}: Props)
)}
</NoWrapNumeric>

<ProjectBadge avatarSize={18} project={!projectsLoaded ? {slug} : project} />
<FlexCenter>
<ProjectBadge avatarSize={18} project={!projectsLoaded ? {slug} : project} />
</FlexCenter>
<NoWrapNumeric>#{incident.id}</NoWrapNumeric>

<FlexCenter>
{teamActor ? (
<Fragment>
<StyledActorAvatar actor={teamActor} size={24} hasTooltip={false} />{' '}
<StyledActorAvatar actor={teamActor} size={18} hasTooltip={false} />{' '}
<TeamWrapper>{teamActor.name}</TeamWrapper>
</Fragment>
) : (
Expand All @@ -88,11 +92,6 @@ const Title = styled('div')`
min-width: 130px;
`;

const NoWrapNumeric = styled('div')`
white-space: nowrap;
font-variant-numeric: tabular-nums;
`;

const ProjectBadge = styled(IdBadge)`
flex-shrink: 0;
`;
Expand All @@ -101,6 +100,12 @@ const FlexCenter = styled('div')`
${p => p.theme.overflowEllipsis}
display: flex;
align-items: center;
line-height: 1.6;
`;

const NoWrapNumeric = styled(FlexCenter)`
white-space: nowrap;
font-variant-numeric: tabular-nums;
`;

const TeamWrapper = styled('span')`
Expand Down