Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sentry/db/models/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,10 @@ def in_iexact(column: str, values: Any) -> Q:
from operator import or_

query = f"{column}__iexact"
# if values is empty, have a default value for the reduce call that will essentially resolve a column in []
query_in = f"{column}__in"

return reduce(or_, [Q(**{query: v}) for v in values])
return reduce(or_, [Q(**{query: v}) for v in values], Q(**{query_in: []}))


def in_icontains(column: str, values: Any) -> Q:
Expand Down
14 changes: 13 additions & 1 deletion tests/sentry/utils/test_query.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
from sentry.models import Team, User
from sentry.db.models.query import in_iexact
from sentry.models import Organization, Team, User
from sentry.testutils import TestCase
from sentry.utils.query import RangeQuerySetWrapper, bulk_delete_objects


class InIexactQueryTest(TestCase):
def test_basic(self):
self.create_organization(slug="SlugA")
self.create_organization(slug="slugB")
self.create_organization(slug="slugc")

assert Organization.objects.filter(in_iexact("slug", ["sluga", "slugb"])).count() == 2
assert Organization.objects.filter(in_iexact("slug", ["slugC"])).count() == 1
assert Organization.objects.filter(in_iexact("slug", [])).count() == 0


class RangeQuerySetWrapperTest(TestCase):
def test_basic(self):
total = 10
Expand Down