Skip to content

fix(sourcemaps): Fix non project #45191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

fix(sourcemaps): Fix non project #45191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6179928
fix(sourcemaps): Fix non project
Feb 28, 2023
666b9bd
Fix comment
Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sentry/lang/javascript/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ def __init__(self, project=None, release=None, dist=None, allow_scraping=True):
self.allow_scraping = allow_scraping

def bind_release(self, release=None, dist=None):
"""Updates the fetcher with a project, release and dist."""
"""Updates the fetcher with a release and dist."""
self.release = release
self.dist = dist

Expand Down Expand Up @@ -900,8 +900,9 @@ def __init__(self, *args, **kwargs):

# Component responsible for fetching the files.
self.fetcher = Fetcher(
project=self.project,
allow_scraping=organization.get_option("sentry:scrape_javascript", True) is not False
and self.project.get_option("sentry:scrape_javascript", True)
and self.project.get_option("sentry:scrape_javascript", True),
Copy link
Contributor

@kamilogorek kamilogorek Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move it outside to allow_scraping var, as its hard to read now.

Copy link
Contributor Author

@iambriccardo iambriccardo Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

)

def get_valid_frames(self):
Expand Down