Skip to content

fix(replay): Fix duration due to incorrect LCP endtimestamp #44842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix(replay): Fix duration due to incorrect LCP endtimestamp #44842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions static/app/utils/replays/replayDataUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export function breadcrumbFactory(
label: error['error.type'].join(''),
eventId: error.id,
groupId: error['issue.id'] || 1,
groupShortId: error.issue || 'POKEDEX-4NN',
Copy link
Member Author

@billyvg billyvg Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is supposed to be here cc @ryan953

groupShortId: error.issue,
project: error['project.name'],
},
timestamp: error.timestamp,
Expand Down Expand Up @@ -263,8 +263,11 @@ export function replayTimestamps(
)
.map(timestamp => +new Date(timestamp * 1000))
.filter(Boolean);
const spanStartTimestamps = rawSpanData.map(span => span.startTimestamp * 1000);
const spanEndTimestamps = rawSpanData.map(span => span.endTimestamp * 1000);
const rawSpanDataFiltered = rawSpanData.filter(
({op}) => op !== 'largest-contentful-paint'
);
const spanStartTimestamps = rawSpanDataFiltered.map(span => span.startTimestamp * 1000);
const spanEndTimestamps = rawSpanDataFiltered.map(span => span.endTimestamp * 1000);

return {
startTimestampMs: Math.min(
Expand Down