Skip to content

feat(perf-issues): Add feature flag for consecutive db issue #42787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2023
Merged

feat(perf-issues): Add feature flag for consecutive db issue #42787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf93cca
feat(perf-issues): Add feature flag for consecutive db issue
DominikB2014 Jan 4, 2023
6d30a9f
Merge remote-tracking branch 'origin/master' into DominikB2014/PERF-1899
DominikB2014 Jan 5, 2023
3d49630
add rollout options
DominikB2014 Jan 5, 2023
327948e
Merge branch 'master' into DominikB2014/PERF-1899
DominikB2014 Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/conf/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,6 +1130,8 @@ def SOCIAL_AUTH_DEFAULT_USERNAME():
"organizations:performance-mep-bannerless-ui": False,
# Enable updated landing page widget designs
"organizations:performance-new-widget-designs": False,
# Enable consecutive db performance issue type
"organizations:performance-consecutive-db-issue": False,
# Enable slow DB performance issue type
"organizations:performance-slow-db-issue": False,
# Enable N+1 API Calls performance issue type
Expand Down
1 change: 1 addition & 0 deletions src/sentry/features/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@
default_manager.add("organizations:performance-mep-bannerless-ui", OrganizationFeature, True)
default_manager.add("organizations:performance-mep-reintroduce-histograms", OrganizationFeature, True)
default_manager.add("organizations:performance-new-widget-designs", OrganizationFeature, True)
default_manager.add("organizations:performance-consecutive-db-issue", OrganizationFeature, True)
default_manager.add("organizations:performance-slow-db-issue", OrganizationFeature, True)
default_manager.add("organizations:profiling", OrganizationFeature)
default_manager.add("organizations:profiling-flamechart-spans", OrganizationFeature, True)
Expand Down
4 changes: 4 additions & 0 deletions src/sentry/options/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,10 @@
register("sentry-metrics.releasehealth.abnormal-mechanism-extraction-rate", default=0.0)

# Individual system-wide options in case we need to turn off specific detectors for load concerns, ignoring the set project options.
register("performance.issues.consecutive_db.problem-creation", default=0.0)
register("performance.issues.consecutive_db.la-rollout", default=0.0)
register("performance.issues.consecutive_db.ea-rollout", default=0.0)
register("performance.issues.consecutive_db.ga-rollout", default=0.0)
register("performance.issues.n_plus_one_db.problem-detection", default=0.0)
register("performance.issues.n_plus_one_db.problem-creation", default=0.0)
register("performance.issues.n_plus_one_db_ext.problem-creation", default=0.0)
Expand Down