ref(hybrid-cloud): use monitor urls with org slug frontend #42728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
nhsiehgit
approved these changes
Jan 3, 2023
davidenwang
approved these changes
Jan 3, 2023
Contributor
davidenwang
left a comment
davidenwang
left a comment
There was a problem hiding this comment.
tested on vercel nothing seems to have changed 👍
This was referenced Jan 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonitorStats, MonitorDetails, and MonitorCheckIns will be region silo endpoints and thus will need org slugs in the url to be able to proxy to the correct region. Updates the frontend to use the urls with the org slug.
For HC-512, HC-513, and HC-514