ref(hybrid-cloud): use organization_slug in MonitorStats #42384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
commented
Dec 15, 2022
|
|
||
| @pending_silo_endpoint | ||
| @region_silo_endpoint | ||
| class MonitorStatsEndpoint(MonitorEndpoint, StatsMixin): |
Member
Author
There was a problem hiding this comment.
there's no test file for this endpoint so there is no test file to convert
Contributor
There was a problem hiding this comment.
The logic looks pretty substantial. Maybe this is a good time to add one?
(To be clear, I'm fine either way. Up to you whether it's worth pausing other work, or if you just want a change of pace.)
Member
Author
There was a problem hiding this comment.
i was going to attempt to write a test file, but the API appears to be broken given what the frontend is passing to it (see any monitor in https://sentry.io/organizations/sentry/monitors/) so i'm not even sure how it works
Member
Author
There was a problem hiding this comment.
i broke it but david helped rearrange the urls
RyanSkonnord
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
organization_slugto the url for theMonitorStatsendpoint. Keeps the original orgless URL for now.Also refactors the test files for
MonitorCheckInsandMonitorDetails.For HC-514