ref(perf): Add interaction transactions for clicks #42266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the 'interactions' to our frontend automatically on click. This will help capture a lot of performance behaviour in SPA's that currently isn't covered, but can be a core part of user journies (eg. settings modals, paywalls etc. are all on-page examples of what might get captured by click interactions). Caveats: - For now our idleTimeout of 5000ms will also apply so for the first interactions we may capture more spans than we should to cover an interaction, as well as the fact that other user behaviour (eg. scroll) isn't currently captured, but can create spans and reset the idleTimeout. - We probably want to add click-targets for click interactions to the interaction themselves to help identify the source of the click. Other: - Sets the rate at 1/100th our sample rate (1% right now) for interactions to keep it low, we can always bump or trend down the number later.
github-actions
bot
added
the
Scope: Frontend
AbhiPrasad
approved these changes
Dec 12, 2022
I just realized, this might cause issues since we are applying dynamic sampling anyway, should we slightly bump it up? |
|
@AbhiPrasad I'd rather keep it on the low end for now in case there are any problems, we can always bump it in another PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the 'interactions' to our frontend automatically on click. This will help capture a lot of performance behaviour in SPA's that currently isn't covered, but can be a core part of user journeys (eg. settings modals, paywalls etc. are all on-page examples of what might get captured by click interactions).
Caveats:
Other: