fix(hybrid-cloud): Update customer domain middleware to support nameless routes #38034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
dashed
force-pushed
the
hybrid-cloud/fix-customer-domain-middleware
branch
from
43cb932 to
f5dcf89
Compare
markstory
approved these changes
Aug 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some routes that are nameless. According to Django docs for
reverse(), I can pass a callable view object in place of a route name: https://docs.djangoproject.com/en/4.1/ref/urlresolvers/#reverseIn addition, I've given some URL parameter names to some routes as
resolve()will match the appropriate route, but will discard any anonymous URL parameter values.