Skip to content

fix(vercel): add sentry env vars to all default environments in Vercel #37649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(vercel): add sentry env vars to all default environments in Vercel #37649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd20cc
fix(vercel): add sentry env vars to all default environments in Vercel
vladanpaunovic Aug 10, 2022
a40f868
chore: update tests
vladanpaunovic Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/integrations/vercel/integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def create_env_var(self, client, vercel_project_id, key, value, type):
data = {
"key": key,
"value": value,
"target": ["production"],
"target": ["production", "preview", "development"],
Copy link
Contributor

@AniketDas-Tekky AniketDas-Tekky Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this a constant or ENUM?

Copy link
Contributor Author

@vladanpaunovic vladanpaunovic Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this is the only place where we need it in this file and I think it is okay to make it explicit like this.

We could, of course, make a constant out of this, and then share this constant with our test in test_integration.py but :) :

  1. I don't know Python that much
  2. I don't know if that is a good practice to assert against a variable that is constant in code

"type": type,
}
try:
Expand Down
24 changes: 12 additions & 12 deletions tests/sentry/integrations/vercel/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def test_update_organization_config(self):
json={
"key": env_var,
"value": details["value"],
"target": ["production"],
"target": ["production", "preview", "development"],
"type": details["type"],
},
)
Expand All @@ -192,30 +192,30 @@ def test_update_organization_config(self):
req_params = json.loads(responses.calls[5].request.body)
assert req_params["key"] == "SENTRY_ORG"
assert req_params["value"] == org.slug
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[6].request.body)
assert req_params["key"] == "SENTRY_PROJECT"
assert req_params["value"] == self.project.slug
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[7].request.body)
assert req_params["key"] == "NEXT_PUBLIC_SENTRY_DSN"
assert req_params["value"] == enabled_dsn
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[8].request.body)
assert req_params["key"] == "SENTRY_AUTH_TOKEN"
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[9].request.body)
assert req_params["key"] == "VERCEL_GIT_COMMIT_SHA"
assert req_params["value"] == "VERCEL_GIT_COMMIT_SHA"
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "system"

@responses.activate
Expand Down Expand Up @@ -270,7 +270,7 @@ def test_update_org_config_vars_exist(self):
json={
"key": env_var,
"value": details["value"],
"target": ["production"],
"target": ["production", "preview", "development"],
"type": details["type"],
},
)
Expand All @@ -292,30 +292,30 @@ def test_update_org_config_vars_exist(self):
req_params = json.loads(responses.calls[5].request.body)
assert req_params["key"] == "SENTRY_ORG"
assert req_params["value"] == org.slug
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[8].request.body)
assert req_params["key"] == "SENTRY_PROJECT"
assert req_params["value"] == self.project.slug
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[11].request.body)
assert req_params["key"] == "SENTRY_DSN"
assert req_params["value"] == enabled_dsn
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[14].request.body)
assert req_params["key"] == "SENTRY_AUTH_TOKEN"
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "encrypted"

req_params = json.loads(responses.calls[17].request.body)
assert req_params["key"] == "VERCEL_GIT_COMMIT_SHA"
assert req_params["value"] == "VERCEL_GIT_COMMIT_SHA"
assert req_params["target"] == ["production"]
assert req_params["target"] == ["production", "preview", "development"]
assert req_params["type"] == "system"

@responses.activate
Expand Down