feat(ui): Change API request exceptions to use cause property
#37262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of parsing and mutating the error stack frames, use the [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) property for API request errors.
github-actions
bot
added
the
Scope: Frontend
Member
Author
|
This is what it looks like in our UI:
|
AbhiPrasad
approved these changes
Jul 29, 2022
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
+1 for using cause more, the SDK has built-in support for it out of the box and we use it internally as well. Are there other places in Sentry where we can do this? Perhaps something to bring up in frontend TSC?
billyvg
commented
Jul 29, 2022
| constructor(method: string | undefined, path: string) { | ||
| super(`${method || 'GET'} ${sanitizePath(path)}`); | ||
| constructor(method: string | undefined, path: string, options: ErrorOptionsObject) { | ||
| super(`${method || 'GET'} "${sanitizePath(path)}"`, options); |
Member
Author
There was a problem hiding this comment.
Had to quote this because of a bug in our SDK
priscilawebdev
approved these changes
Aug 1, 2022
Member
Author
|
@AbhiPrasad Not sure where else we could use this, but definitely agree we should use it more when possible |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of parsing and mutating the error stack frames, use the cause property for API request errors. This also solves some cases where the stack manipulation did not work on certain browsers.