Skip to content

Conversation

@macqueen
Copy link
Contributor

fixes #2875

@getsentry/ui

@codecov-io
Copy link

Current coverage is 82.41%

Merging #3076 into master will increase coverage by +0.09% as of dd98678

@@            master   #3076   diff @@
======================================
  Files          932     934     +2
  Stmts        36641   36717    +76
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit          30163   30260    +97
  Partial          0       0       
+ Missed        6478    6457    -21

Review entire Coverage Diff as of dd98678

Powered by Codecov. Updated on successful CI builds.

@mattrobenolt
Copy link
Contributor

@macqueen Do we not need that for other pages? Or are we trying to just remove the zoom from the login page?

tbh I barely have any idea what this is doing, just making sure you're intending for it to be applied to every page.

@macqueen
Copy link
Contributor Author

@mattrobenolt i figured @ckj could comment on how important the zoom is. my thought was that it doesn't change that much and could be breaking other things, so might as well get rid of it. but yes, if we have a reason to keep it, just removing zoom for login page is an option.

@ckj
Copy link
Member

ckj commented Apr 20, 2016

@macqueen Nice catch! How about we just remove zoom from auth pages? I think there's an .auth body class we can hook on to in layout.less.

We're kind of relying on the zoom stuff to get things to fit better on smaller screens. I think eventually we'll remove it in favor of another approach, but that's further down the road.

@ckj
Copy link
Member

ckj commented Apr 29, 2016

Sorry didn't see this notification. Looks great, +1.

@macqueen macqueen merged commit 690ac00 into master Apr 29, 2016
@macqueen macqueen deleted the captcha-css branch April 29, 2016 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Captcha on Sign-In Broken on Phones

5 participants