Skip to content

Add mobile ui operation breakdown #30363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 29, 2022
Merged

Add mobile ui operation breakdown #30363

merged 9 commits into from
Jun 29, 2022

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Dec 2, 2021 •
edited
Loading

Adding one more operation (mobile), related to #24025

@dashed dashed requested a review from a team December 2, 2021 17:53
@dashed
Copy link
Member

dashed commented Dec 2, 2021

@marandaneto Are you only interested in being able to query for these in Discover?

AbhiPrasad
AbhiPrasad approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: https://develop.sentry.dev/sdk/performance/span-operations/

This was referenced Dec 2, 2021
Merged
Merged
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2021

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot closed this Dec 31, 2021
@dashed
Copy link
Member

dashed commented Jan 1, 2022

@marandaneto Is this still something you want to have? If so, what was preventing this from being merged after it was promptly approved?

@untitaker untitaker reopened this Jan 3, 2022
untitaker
untitaker approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the snapshot changes are fine as-is

@marandaneto marandaneto enabled auto-merge (squash) March 21, 2022 13:52
@marandaneto
Copy link
Contributor Author

marandaneto commented Apr 4, 2022

@dashed @k-fish since this PR was never merged and CI was never totally happy due to other reasons not related to this PR, can we just merge it? I don't contribute to this repo so I'm unsure if this is ok or not.

@dashed
Copy link
Member

dashed commented Apr 4, 2022

@untitaker would you be able to assist on the metrics tests that are failing in this PR? 🙏

@untitaker
Copy link
Member

untitaker commented Apr 5, 2022

fixed. but tbh this can be done by anybody with a functioning devsetup :)

@dashed
Copy link
Member

dashed commented Apr 5, 2022

@untitaker 🌮

@marandaneto I think you can just rebase to master, and you should be able to finally merge this PR. :D

@marandaneto
Copy link
Contributor Author

marandaneto commented Apr 6, 2022

@untitaker 🌮

@marandaneto I think you can just rebase to master, and you should be able to finally merge this PR. :D

relay test still fails :(

@untitaker
Copy link
Member

untitaker commented Apr 6, 2022 via email

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 29, 2022
@marandaneto marandaneto merged commit c4f098f into master Jun 29, 2022
@marandaneto marandaneto deleted the enha/add-ui-mobile-op-breakdown branch June 29, 2022 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dashed dashed dashed approved these changes

@untitaker untitaker untitaker approved these changes

@k-fish k-fish k-fish approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@marandaneto marandaneto

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marandaneto @dashed @untitaker @k-fish @AbhiPrasad