Skip to content

Conversation

@priscilawebdev
Copy link
Member

@priscilawebdev priscilawebdev commented Jul 13, 2021

Previews:

Light mode:
image

image

image

Dark mode:

image

image -> the drop down needs some tweak

  • Removes EmptyState - we don't want to have it
  • Adds Visualization Dialog - it takes the whole page according to the image size, otherwise the image would like weird

in a follow-up PR

  • Fix double attachment request
  • Tests

}
function hasScreenshot(attachment: EventAttachment) {
const {mimetype} = attachment;
return mimetype === 'image/jpeg' || mimetype === 'image/png';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to have name === 'screenshot' here in the future

@priscilawebdev priscilawebdev requested a review from a team July 13, 2021 09:19
@priscilawebdev priscilawebdev enabled auto-merge (squash) July 13, 2021 09:21
@priscilawebdev priscilawebdev merged commit 6d38a7c into master Jul 13, 2021
@priscilawebdev priscilawebdev deleted the feat/mobile-screenshots-visualization-modal branch July 13, 2021 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants