fix: Bump sentry-sdk to git sha #22552
Conversation
evanpurkhiser
left a comment
evanpurkhiser
left a comment
There was a problem hiding this comment.
do you have a PR for getsentry too?
|
Oh I can't push to master there anymore, can't I. Yeah will create one |
| # [end] jsonschema format validators | ||
| sentry-relay>=0.8.1,<0.9.0 | ||
| sentry-sdk>=0.17.7,<0.18.0 | ||
| sentry-sdk @ git+https://github.com/getsentry/sentry-python@c277ed5#egg=sentry-sdk |
There was a problem hiding this comment.
This prevents us from deploying to PyPI so I'll have to block this PR unfortunately.
| && buildDeps="" \ | ||
| # ability to install git dependencies | ||
| && buildDeps="$buildDeps \ | ||
| git \ |
There was a problem hiding this comment.
We won't be shipping git in prod images ever. If you ever need it, it should probably be in the builder image: https://github.com/getsentry/sentry/blob/master/docker/builder.dockerfile
There was a problem hiding this comment.
fwiw this is installed and uninstalled within the same build step, as all buildDeps.
There was a problem hiding this comment.
oh, right missed that. Still it would be ideal not to use git. Will propose something below.
| && buildDeps="" \ | ||
| # ability to install git dependencies | ||
| && buildDeps="$buildDeps \ | ||
| git \ |
There was a problem hiding this comment.
oh, right missed that. Still it would be ideal not to use git. Will propose something below.
| # [end] jsonschema format validators | ||
| sentry-relay>=0.8.1,<0.9.0 | ||
| sentry-sdk>=0.17.7,<0.18.0 | ||
| sentry-sdk @ git+https://github.com/getsentry/sentry-python@c277ed5#egg=sentry-sdk |
There was a problem hiding this comment.
| sentry-sdk @ git+https://github.com/getsentry/sentry-python@c277ed5#egg=sentry-sdk | |
| sentry-sdk @ https://github.com/getsentry/sentry-python/archive/c277ed5d1170a7d58fe3482173d391ae799fdc0a.zip#egg=sentry-sdk |
wanna get getsentry/sentry-python#942 in
#sync-getsentry