fix(discover) Fix user.display in aggregates #20329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the full column function in the group by clause so that we don't get errors about ungrouped fields. Refs SENTRY-GWT
Mostly remove the string formatting for ArgValue substitutions. Using ArgValue lets us expand function parameters into other expressions.
Contributor
size-limit report
|
evanh
approved these changes
Aug 21, 2020
src/sentry/api/event_search.py
Outdated
| "count": { | ||
| "name": "count", | ||
| "args": [CountColumn("column")], | ||
| "args": [NoColumn("column")], |
Member
There was a problem hiding this comment.
It's valid to have an empty args array here, unless the frontend is still passing through count() values with something inside the function call. Not sure why we need this new class.
Member
Author
There was a problem hiding this comment.
I can remove it. I was originally trying to make a class that swallowed the argument and didn't forward it, but that made other parts of function resolution angry. I'll remove it.
Zylphrex
reviewed
Aug 21, 2020
Co-authored-by: evanh <[email protected]>
Co-authored-by: Tony <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few issues that have come up around aggregates and the new user.display field.
count_unique()function requires an argument or it ends up with a None inside that makes snuba very sad.count_unique(user.display)expression now does the right thing. I've migrated most of the functions away from string formatting as it makes handling complex fields inside aggregates simpler. I've not removed string formatting of function arguments as @wmak is leaning on it in one of his open pull requests.