fix(pickle): Do not use bare-except when unpickling db value #18934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
reviewed
May 20, 2020
| # v1.0.0 with one change: We re-raise any baseexceptions such as | ||
| # signals. 1.0.0 has a bare `except:` which causes issues. | ||
|
|
||
| if value is not None: |
Contributor
There was a problem hiding this comment.
Quite honestly I would always reraise. If depickling fails, why would I ever want the raw value to be returned?
Member
Author
There was a problem hiding this comment.
i thought this method had to be idempotent because of django?
Contributor
There was a problem hiding this comment.
Apparently this is expected to be idempotent. Let's try it like this first.
mitsuhiko
approved these changes
May 20, 2020
| # v1.0.0 with one change: We re-raise any baseexceptions such as | ||
| # signals. 1.0.0 has a bare `except:` which causes issues. | ||
|
|
||
| if value is not None: |
Contributor
There was a problem hiding this comment.
Apparently this is expected to be idempotent. Let's try it like this first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are encountering a bug where we read double-pickled values for
project options. We suspect that during a deploy, django-picklefield
catches a SystemExit or KeyboardInterrupt here:
https://github.com/gintas/django-picklefield/blob/v1.0.0/src/picklefield/fields.py#L124