fix: APM React Profiler call #17370
Merged
fix: APM React Profiler call #17370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Feb 28, 2020
mitsuhiko
approved these changes
Feb 28, 2020
dashed
reviewed
Feb 28, 2020
| description: `<${displayName}>`, | ||
| }, | ||
| { | ||
| autoPopAfter: 500, // After this timeout we'll pop this activity regardless |
Member
There was a problem hiding this comment.
@HazAT Does this mean if the react component is waiting for a request that takes longer than 500ms to finish before ending this span, it will automatically pop after 500ms?
Member
Author
There was a problem hiding this comment.
@billyvg Yes, exactly, so renders now never take longer than 500ms, and the span will be marked with the status Deadline_Exceeded.
One example when this occurred:
Sometimes when you navigation change into the project creation page in Sentry, the render activity was started but never ended, that's how we determined this "bug".
So I know this is not ideal but I had no idea how to debug why sometimes the profiler is not calling finish.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of why can be found here: getsentry/sentry-javascript#2459