ref: revise setup.py, remove stray license headers #16174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 18, 2019 14:52
dcramer
approved these changes
Dec 18, 2019
BYK
approved these changes
Dec 19, 2019
| import sys | ||
|
|
||
| if sys.version_info[:2] != (2, 7): | ||
| sys.exit("Error: Sentry requires Python 2.7.") |
| BuildJsSdkRegistryCommand, | ||
| ) | ||
|
|
||
| # The version of sentry |
|
|
||
| IS_LIGHT_BUILD = os.environ.get("SENTRY_LIGHT_BUILD") == "1" | ||
|
|
||
| # we use pip requirements files to improve Docker layer caching |
Member
There was a problem hiding this comment.
I think this may stay? At least until we move to poetry? 
Member
Author
There was a problem hiding this comment.
The future is mysterious and hopefully bright!
| These are additional urls used by the Sentry-provided web server | ||
| :copyright: (c) 2012 by the Sentry Team, see AUTHORS for more details. |
Member
There was a problem hiding this comment.
Let me quote the PR title:
ref: revise setup.py
This file says src/sentry/conf/urls.py - I sense contradictions in you but the force is strong.
Member
Author
There was a problem hiding this comment.
scope creep gets the best of us, haha
joshuarli
changed the title
scefali
pushed a commit
that referenced
this pull request
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few small things, see commit messages.
Also removed some stray license headers missed by #14095.